This repository has been archived by the owner on May 26, 2022. It is now read-only.
update quic-go to v0.12.0 (supporting QUIC draft-22) #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
update-to-quic-draft-22
branch
from
08a5289
to
c75974c
Compare
Stebalien
approved these changes
Aug 5, 2019
| @@ -36,13 +38,13 @@ func (c *conn) IsClosed() bool { | |||
|
|
|||
| // OpenStream creates a new stream. | |||
| func (c *conn) OpenStream() (mux.MuxedStream, error) { | |||
| qstr, err := c.sess.OpenStreamSync() | |||
| qstr, err := c.sess.OpenStreamSync(context.Background()) | |||
There was a problem hiding this comment.
We should probably set a timeout. 5s?
(ideally, the context would be passed through but that's better than nothing)
There was a problem hiding this comment.
That might be a fix for #57. Let's do that in a separate PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates quic-go to the latest release. This release increases the QUIC version number to draft-22. This gives us the opportunity to change our handshake logic, so we should merge this PR at the same time as #67.