Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

fix data race in allowWindowIncrease #259

Merged
merged 1 commit into from
Feb 7, 2022
Merged

fix data race in allowWindowIncrease #259

merged 1 commit into from
Feb 7, 2022

Conversation

mudler
Copy link
Contributor

@mudler mudler commented Feb 6, 2022 •
edited by marten-seemann
Loading

Fixes #260

Trying this out to see if races are disappearing

@mudler mudler mentioned this pull request Feb 7, 2022
Closed
marten-seemann
marten-seemann approved these changes Feb 7, 2022
View reviewed changes
Copy link
Collaborator

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this definitely needs the mutex.

@marten-seemann marten-seemann changed the title Prevent data race in allowWindowIncrease fix data race in allowWindowIncrease Feb 7, 2022
@marten-seemann marten-seemann merged commit 9df78c4 into libp2p:master Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race condition in allowWindowIncrease
2 participants
@mudler @marten-seemann