This repository has been archived by the owner on May 26, 2022. It is now read-only.
reduce the zstd window size from 8 MB to 32 KB #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarks using sample qlog files show that this achieves in improvement in both compression efficiency and compression speed. More importantly, it prevents us from allocating a 8 MB every time a QUIC connection is closed.
Stebalien
approved these changes
Feb 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks using sample qlog files show that this achieves in improvement in both compression efficiency and compression speed.
More importantly, it prevents us from allocating a 8 MB every time a QUIC connection is closed.
See klauspost/compress#316.