This repository has been archived by the owner on May 26, 2022. It is now read-only.
add support for multiaddr filtering #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
filters
branch
2 times, most recently
from
0791f59
to
579a74d
Compare
Stebalien
approved these changes
Mar 16, 2020
| n, addr, rerr = c.PacketConn.ReadFrom(b) | ||
| // Short Header packet, see https://tools.ietf.org/html/draft-ietf-quic-invariants-07#section-4.2. | ||
| if n < 1 || b[0]&0x80 == 0 { | ||
| return |
There was a problem hiding this comment.
Can we ever read a partial packet and would that cause an issue?
There was a problem hiding this comment.
In principle, yes. If the UDP packet is longer than b, ReadFrom will only read the packet up to len(b), the rest of the packet will be discarded. Since every QUIC packet is integrity protected, this doesn't lead to any problems, as the partial packet will simply end up undecryptable.
QUIC itself deals with the problem of fixed buffer sizes by communication a max_packet_size during the handshake, so the endpoint knows not to pack any packet that is larger than its peer's buffer.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124.
When multiplexing incoming and outgoing connections on the same packet conn, quic-go expects the packet conns to be the same struct. Therefore, filters are applied for incoming and outgoing connections.