Use atomic counter for message seqnos #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
so I don't know what's the deal with the jenkins tests: it says "passed but marked as unstable". |
| binary.BigEndian.PutUint64(seqno, uint64(time.Now().UnixNano())) | ||
| seqno := make([]byte, 16) | ||
| counter := atomic.AddUint64(&p.counter, 1) | ||
| binary.BigEndian.PutUint64(seqno[:8], uint64(time.Now().UnixNano())) |
There was a problem hiding this comment.
If we initially set counter to time.Now().UnixNano(), then we don't need to get the current time every time we send a message.
Not a big deal, but might save us some syscalls
There was a problem hiding this comment.
It also saves us from having to send a whole extra 8 bytes per message
There was a problem hiding this comment.
good points, nice small efficiencies. i'll open a new PR.
There was a problem hiding this comment.
actually, there is no syscall involved in getting the time; but still.
This was referenced Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52
The seqno is now the concatenation of the timestamp and an atomic counter; it's 128-bit wide.