Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix goroutine build up from connected notifications #430

Merged
merged 8 commits into from
Jul 13, 2021
Merged

fix goroutine build up from connected notifications #430

merged 8 commits into from
Jul 13, 2021

Commits on Jul 13, 2021

  1. don't accumulate pending goroutines from new connections

    @vyzo
    vyzo committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    9ffb307 View commit details
    Browse the repository at this point in the history

  2. use a semaphore for new peer notifications so that we don't block the… 

    … event loop
    @vyzo
    vyzo committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    a123864 View commit details
    Browse the repository at this point in the history

  3. emit new peer notification without holding the semaphore

    @vyzo
    vyzo committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    c2c68ab View commit details
    Browse the repository at this point in the history

  4. do the notification in a goroutine 

    don't block the swarm while waiting for the semaphore.
    @vyzo
    vyzo committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    14213be View commit details
    Browse the repository at this point in the history

  5. use a priority lock instead of a semaphore 

    so that there is no case of infinite accumulation of pending peers in the queue.
also adds a connectedness check before adding the peer.
    @vyzo
    vyzo committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    5671c61 View commit details
    Browse the repository at this point in the history

  6. batch process dead peer notifications

    @vyzo
    vyzo committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    2c153fe View commit details
    Browse the repository at this point in the history

  7. don't respawn writer if we fail to open a stream; declare it a peer e… 

    …rror
    @vyzo
    vyzo committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    e4bb1a5 View commit details
    Browse the repository at this point in the history

  8. release priority locks early when handling batches

    @vyzo
    vyzo committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    f890ce8 View commit details
    Browse the repository at this point in the history