Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop search after a good value is found #12

Merged
merged 2 commits into from
Sep 29, 2018
Merged

Stop search after a good value is found #12

merged 2 commits into from
Sep 29, 2018

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Sep 27, 2018

@ghost ghost assigned magik6k Sep 27, 2018
@ghost ghost added the status/in-progress In progress label Sep 27, 2018
@magik6k magik6k changed the title stop after a good value is found Stop search after a good value is found Sep 27, 2018
@magik6k
Copy link
Contributor Author

magik6k commented Sep 28, 2018

Btw, consider this and the routing-helpers PR (libp2p/go-libp2p-routing-helpers#12) work in progress as there are still some issues I'm trying to debug.

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm still a bit worried that there's no definition for "good" in IPNS over pubsub but that's a more general issue.

@magik6k magik6k merged commit 4cec719 into master Sep 29, 2018
@ghost ghost removed the status/in-progress In progress label Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants