This repository has been archived by the owner on May 26, 2022. It is now read-only.
remove key serialization, construct conn from ipnet.PSK #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
marten-seemann
force-pushed
the
generalize-private-network
branch
from
a1935f1
to
c943fea
Compare
marten-seemann
requested review from
raulk and
Kubuxu
and removed request for
raulk
|
comment moved to libp2p/go-libp2p#795 (comment) |
marten-seemann
force-pushed
the
generalize-private-network
branch
from
1073b46
to
c943fea
Compare
Stebalien
added
the
status/blocked
|
Let's leave off merging this till everything is ready. |
|
Any idea why the tests are failing? |
|
@Stebalien All the PRs listed in libp2p/go-libp2p#795 should be ready for merging. |
Stebalien
removed
the
status/blocked
Stebalien
force-pushed
the
generalize-private-network
branch
from
c943fea
to
009bf67
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libp2p/go-libp2p-core#118 removes the
ipnet.Protectorinterfaces and replaces it by anipnet.PSK(which is a named type for[]byte). Arguably, serialization of keys to a format that's storable on disk (and the corresponding deserialization) doesn't belong into libp2p, but should be the responsibility of the application using libp2p.Therefore, this PR removes all serialization and deserialization functions. I will move them to IPFS in another PR.
Tracking issue: libp2p/go-libp2p#795.