Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

catch panics during the handshake #111

Merged
merged 1 commit into from
Apr 19, 2022
Merged

catch panics during the handshake #111

merged 1 commit into from
Apr 19, 2022

Conversation

marten-seemann
Copy link
Contributor

@marten-seemann marten-seemann commented Apr 19, 2022 •
edited
Loading

Stebalien
Stebalien approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But we could also just drop it inside newSecureSession.

Stebalien
Stebalien suggested changes Apr 19, 2022
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. Actually, this doesn't work. We need to catch it inside the goroutine inside newSecureSession. Or inside runHandshake

@Stebalien
Copy link
Member

Inside runHandshake is probably the best place to put this.

@marten-seemann marten-seemann merged commit 56834d1 into master Apr 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marten-seemann @Stebalien