feat: findProvidersAsync #938
Conversation
dennis-tra
force-pushed
the
v2-issue-915-find-providers-async
branch
from
63122cb to
f1dacf1
Compare
| @@ -78,6 +78,33 @@ func TestConfig_Validate(t *testing.T) { | |||
| assert.Error(t, cfg.Validate()) | |||
| }) | |||
|
|
|||
| t.Run("backends for ipfs protocol (public key missing)", func(t *testing.T) { | |||
There was a problem hiding this comment.
It is possible to support only one or two backends? Suppose we don't want to support IPNS records - do we still need to declare it in the config?
There was a problem hiding this comment.
Yes, that's possible but only if the configured protocol is not /ipfs/kad/1.0.0. This was recommended by Adin (can't find the link to the conversation).
I'm trying to enforce that if someone configures the DHT with the /ipfs/kad/1.0.0 protocol, all the required backends are there. If someone wants to, they can still misconfigure it - but this makes it harder.
|
|
||
| // verify if this DHT supports provider records by checking | ||
| // if a "providers" backend is registered. | ||
| b, found := d.backends[namespaceProviders] |
There was a problem hiding this comment.
Can we search for providers without having a backend to store them? How would that work?
There was a problem hiding this comment.
Actually, when we search for providers, we won't store them anywhere. This is just checking if we support providers. Other users could configure custom backends for other types of records but the DHT will still support the routing.Routing interface. In that case we won't have the right backend configured here.
| panic("implement me") | ||
| // first fetch the record locally | ||
| stored, err := b.Fetch(ctx, string(c.Hash())) | ||
| if err != nil { |
There was a problem hiding this comment.
This would be necessary if this was the datastore Get method. This is the backend Fetch method. The backend returns a *providerSet. If there are no providers, the set will be empty. IIRC internally the backend will query the datastore (not Get). This means even the datastore won't return a NotFound error.
| case out <- provider: | ||
| } | ||
|
|
||
| if count != 0 && len(providers) == count { |
There was a problem hiding this comment.
count != 0 isn't strictly necessary since len(providers) can never be zero here
fixes: #915