feat: delete GetValues

[Stebalien]

This was a somewhat strange interface that returned one value from each peer. It has been replaced by SearchValue that returns better and better values as we get them.

In the future, we should be able to introduce a new GetValues that returns a "bag" of values (possibly multiple values from individual peers).

fixes #416

While breaking, there are currently no users of this method. This used to be used in namesys, but that now uses SearchValue.

[aschmahmann]

While breaking, there are currently no users of this method. This used to be used in namesys, but that now uses SearchValue.

If actually nobody is using this let's kill it, it doesn't seem super useful.

In the future, we should be able to introduce a new GetValues that returns a "bag" of values (possibly multiple values from individual peers).

The current setup only really allows returning a single value from a peer for a given key (e.g. IPNS records). If we landed something like #584 then having multiple values per peer would be a possibility.

[aschmahmann]

Side note: CI seems to be flipping out here, any idea what's up?

[Stebalien]

The current setup only really allows returning a single value from a peer for a given key (e.g. IPNS records). If we landed something like #584 then having multiple values per peer would be a possibility.

Yeah, this just clears the way a bit.

Side note: CI seems to be flipping out here, any idea what's up?

Flakes. There are a lot of flakes.

[Stebalien]

@aschmahmann can I merge?

[aschmahmann]

Sure, let's kill it. We should make sure to note it in the release notes though