Boostrap empty RT and Optimize allocs when we discover new peers #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
May 8, 2020
| @@ -504,9 +561,6 @@ func (dht *IpfsDHT) peerStoppedDHT(ctx context.Context, p peer.ID) { | |||
| // A peer that does not support the DHT protocol is dead for us. | |||
| // There's no point in talking to anymore till it starts supporting the DHT protocol again. | |||
| dht.routingTable.RemovePeer(p) | |||
|
|
|||
| // since we lost a peer from the RT, we should do this here | |||
| dht.fixRTIfNeeded() | |||
There was a problem hiding this comment.
Should we not do this? The idea was to fix our routing table if we drop below some number of peers.
There was a problem hiding this comment.
I guess the periodic bootstrap will help.
There was a problem hiding this comment.
@Stebalien Should have added a comment here. The dht.routingTable.RemovePeer call will result into a call to the Peer Removed callback which in turns calls fixRTIfNeeded .
|
@Stebalien Have made the change in core & peerstore. Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Stebalien
For #387(one part of it) and #594:
SupportProtocolsand reduce allocs in RT when we add a new peer.Please review associated PRs: