Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Finish dependency extraction #6

Merged
merged 5 commits into from
Sep 4, 2016
Merged

Conversation

geoah
Copy link
Member

@geoah geoah commented Aug 25, 2016

Warning: This is still work in progress, please do not merge yet.

Recapping from #5:

@geoah
Copy link
Member Author

geoah commented Sep 3, 2016

Travis is green; I think I'm gonna cry.
The problem is that this is a bit long... @whyrusleeping

There are some things that need to me merged and pinned before this can me merged.
I tried to check everything for dupes. Hope I didn't miss anything.

The result is...

gx deps -r -s
autobatch           QmSp3diFRRv4zR25nHU4MWNCdhT4R6cxrTPLx12MCi1TZb 0.2.2
base32              Qmb1DA2A9LS2wR4FFweB4uEDomFsdmnw1VLawLE1yQzudj 0.0.0
bbloom              QmWQ2SJisXwcCLsUXLwYCKSfyExXjFRW2WbBH5sqCUnwX5 0.0.2
dns                 QmWchsfMt9Re1CQaiHqPQC1DrZ9bkpa6n229dRYkGyLXNh 0.0.0
gateway             Qmf2fBLzCvFxs3vvZaoQyKSTv2rjApek4F1kzRxAfK6P4P 1.0.4
go-base58           QmT8rehPR3F6bmwL6zjUN8XpiDBFFpMP2myPdC6ApsWfJf 0.0.0
go-cienv            QmZcUXuzsUSvxNj9pmU112V8L5kGUFMTYCdFcAbQ3Zj5cp 0.0.0
go-colorable        QmdvecVcFhbo5x4f3arqmfxyE3NzqwWyp77KzA68EKXJeX 0.0.4
go-context          QmX6DhWrpBB5NtadXmPSXYNdVvuLfJXoFNMvUMoVvP5UJa 0.0.0
go-crypto           Qme1boxspcQWR8FBzMxeppqug2fYgYc15diNWmqgDVnvn2 0.0.0
go-datastore        QmbzuUusHqaLLoNTDEVLcSF6vZDHZDLPC7p4bztRvvkXxU 1.0.0
go-detect-race      QmQHGMVmrsgmqUG8ih3puNXUJneSpi13dkcZpzLKkskUkH 0.0.0
go-ipfs-util        QmZNVWh8LLjAavuQ2JXuFmuYH3C11xo988vSgp7UQrTRj1 1.0.0
go-key              Qmce4Y4zg3sYr7xKM5UueS67vhNni6EeWgCRnb7MbLJMew 1.0.2
go-keyspace         QmUusaX99BZoELh7dmPgirqRQ1FAmMnmnBn3oiqDFGBUSc 1.0.0
go-libp2p           QmUEtj7KAkoLULwUHm4KA4pbRAcziPLHpHDRQsvn9g1i6t 3.4.2
go-libp2p-crypto    QmVoi5es8D5fNHZDqoW6DgDAEPEV5hQp8GBz161vZXiwpQ 1.0.4
go-libp2p-kbucket   Qmc5r13R4j3V75ucMkGzHimsQDgkg4aUanX5upcUWns7XM 1.0.1
go-libp2p-loggables QmYrv4LgCC8FhG2Ab4bwuq5DqBdwMtx3hMb3KKJDZcr2d7 1.0.11
go-libp2p-peer      QmWXjJo15p4pzT7cayEwZi2sWgJqLnGDof6ZGMh9xBgU1p 2.0.4
go-libp2p-peerstore QmXhhVSpXMUjpf9XgQDyePxug2iHm8ZvZD99aA9N6kuqMN 1.2.3
go-libp2p-record    Qme7D9iKHYxwq28p6PzCymywsYSRBx9uyGzW7qNB3s9VbC 1.0.1
go-libp2p-routing   QmYQadj3iegqmRPWjaWMRc8DG52hZa2HMkmyPkto5chDvs 1.0.1
go-libp2p-secio     QmbnPJidHfeekkdLkoboBooA56KB92cT8csDmJwCc2bQJ1 1.0.12
go-libp2p-transport QmQCGn5uWpL1wWntVzCWQrNmXBZ5a1PXbxZNFtPPbFk3KC 1.3.6
go-log              QmSpJByNKFX1sCsHBEp3R73FL4NF6FnQTEGyNAXHm2GS52 1.2.0
go-logging          QmQvJiADDe7JR4m968MwXobTCCzUqQkP87aRHe29MEBGHV 0.0.0
go-metrics          QmeYJHEk8UjVVZ4XCRTZe6dFQrb8pGWD81LYCgeLp8CvMB 0.0.0
go-msgio            QmRQhVisS8dmPbjBUthVkenn81pBxrx1GxE281csJhm2vL 0.0.0
go-multiaddr        QmYzDkkgAEmrcNzFCiYo6L1dTX4EAG1gZkbtdbd9trL4vd 0.0.0
go-multiaddr-net    QmPpRcbNUXauP3zWZ1NJMLWpe4QnmEHrd2ba2D3yqWznw7 1.2.0
go-multihash        QmYf7ng2hG5XBtJA3tN34DQ2GUN5HNksEw1rLDkmr6vGku 0.0.0
go-multistream      QmatJnBK2qyjcy1AYq4Gb5YH16YM7uibdteQ589r46YLvB 0.3.1
go-nat              QmYabcy8kaP658zZRZHLqRquJ37ycNWr4qhBL25tUodZWc 0.0.0
go-nat-pmp          QmYsYNh6saxUYHajdj49uiRzdxQgiFTtymrjf3d1f2Cer4 1.0.1
go-net              QmZy2y8t9zQH2a1b8q2ZSLKp17ATuJoCNxxyMFG5qFExpt 0.0.0
go-net-resolve-addr Qma73Sqt13DzHzveZ667BBfraM7MuMrPepUXjmv812JhRS 0.0.0
go-notifier         QmbcS9XrwZkF1rZj8bBwwzoYhVuA2PCnPhFUL1pyWGgt2A 0.0.0
go-peerstream       QmduCCgTaLnxwwf9RFQy2PMUytrKcEH9msohtVxSBZUdgu 1.0.0
go-randbuf          QmYNGtJHgaGZkpzq8yG6Wxqm6EQTKqgpBfnyyGBKbZeDUi 0.0.0
go-reuseport        QmaaC9QMYTQHCbMq3Ebr3uMaAR2ev4AVqMmsJpgQijAZbJ 0.0.0
go-semver           QmcrrEpx3VMUbrbgVroH3YiYyUS5c4YAykzyPJWKspUYLa 0.0.0
go-smux-multistream Qme8hbiTP4VNr1s7FxsfnnqrxbxPz3KPWtuGYeGbtFnhGC 1.3.1
go-smux-spdystream  QmYVkdUUNyPfPGYKc49TMd9BV8ByxRgoCauaZghh3bu81d 1.0.1
go-smux-yamux       QmSHTSkxXGQgaHWz91oZV3CDy3hmKmDgpjbYRT6niACG4E 1.1.1
go-sockaddr         QmcLqWSFsaQ8Ujh8Ys8i9JPHVy1CcdPoqV23M9S3ufdVbn 0.0.0
go-stream-muxer     Qmb1US8uyZeEpMyc56wVZy2cDFdQjNFojAUYVCoo9ieTqp 1.0.0
go-temp-err-catcher QmWHgLqrghM9zw77nF6gdvT9ExQ2RB9pLxkd8sDHZf1rWb 0.0.0
go-testutil         QmYpVUnnedgGrp6cX2pBii5HRQgcSr778FiKVe7o7nF5Z3 1.0.2
go-text             Qmaau1d1WjnQdTYfRYfFVsCS97cgD8ATyrKuNoEfexL7JZ 0.0.0
go-todocounter      QmQNQhNmY4STU1MURjH9vYEMpx2ncMS4gbwxXWtrEjzVAq 1.0.1
go.uuid             QmcyaFHbyiZfoX5GTpcqqCPYmbjYNAhRDekXSJPFHdYNSV 1.0.0
gogo-protobuf       QmZ4Qi3GaRbjcx28Sme5eMH7RQjGkt8wHxt2a65oLaeFEV 0.0.0
golang-lru          QmVYxfoJQiZijTgPNHCHgHELvQpbsJNTg6Crmc3dQkj3yy 0.0.0
goprocess           QmQopLATEYMNg7dVqZRNDfeE2S1yKy8zrRh5xnYiuqeZBn 0.0.0
goprocess           QmSF8fPo3jgVBAy8fpdjjYqgG87dkJgUprRBHRd2tmfgpP 1.0.0
gorocheck           QmTd4Jgb4nbJq5uR55KJgGLyHWmM3dovS21D1HcwRneSLu 0.0.0
goupnp              QmQPxwSLpNZAC1BTbAw5szh9QSLNVx62DK6jEYC8uipYGk 0.0.0
mafmt               QmeLQ13LftT9XhNn22piZc3GP56fGqhijuL5Y8KdUaRn1g 1.1.1
mdns                QmSscYPCcE1H3UQr2tnsJ2a9dK9LsHTBGgP71VW6fz67e5 0.0.0
missinggo           QmeQKXFrogdhUZ5LJpJFa4jQgwX8edLzKft6GskfJR2yJT 0.0.0
multiaddr-filter    QmSMZwvs3n4GBikZ7hKzT17c3bk65FmyZo2JqtJ16swqCv 1.0.2
pb                  QmeWjRodbcZFKe5tMN7poEx3izym6osrLSnTLf9UjJZBbs 1.0.3
randbo              QmYvsG72GsfLgUeSojXArjnU6L4Wmwk7wuAxtNLuyXcc1T 0.0.0
spdystream          QmVdtNvi3madh1HtiX4HByrpjQqkkHUYh6DARq2QC6NxXt 0.0.0
sync                Qmc2wJGUy2Gr9CyXNkUewoK6LRn9nnbBCrM6f9qap4xTNP 0.0.0
utp                 QmPSR1zYgWRmTSt6nTGXdeeUhWkq9AdvK4sva4Y2H5daPi 0.0.0
websocket           QmTDQRD9abCLfdZCjVxuujSVq1X7pkW8eXhaJtgsjH2fnT 0.0.0
ws-transport        Qmb5uXFWQMcJdJK6nMSZ92HRvc1okWutVgLFsyesKdpemc 1.0.6
yamux               QmZ8MMKFwA95viWULoSYFZpA4kdFa8idmFSrP12YJwjjaL 1.0.1

@JesseWeinstein
Copy link

Wow, nice work.

@JesseWeinstein
Copy link

Why did you change the meaning of pb from github.com/ipfs/go-ipfs/routing/dht/pb from to github.com/libp2p/go-libp2p-kad-dht/pb? I see that you moved the contents of github.com/ipfs/go-ipfs/routing/dht/pb to github.com/libp2p/go-libp2p-record/pb -- but why change the shortname to recpb?

@geoah
Copy link
Member Author

geoah commented Sep 4, 2016

@JesseWeinstein the pb package has been split into two

  1. Message is now in github.com/libp2p/go-libp2p-kad-dht/pb
  2. Record is now in github.com/libp2p/go-libp2p-record/pb

In dht.go both pb packages are imported so I preferred to keep the dht one shorthanded as pb while the record as recpb.

If you disagree or have a better suggestion let me know and I'll be happy to change it :)

    pb "github.com/libp2p/go-libp2p-kad-dht/pb"
    recpb "github.com/libp2p/go-libp2p-record/pb"

@whyrusleeping
Copy link
Contributor

@geoah great work, i'm working through merging those now.

Random gx tip of the day:

To see whats changed between two package hashes, use gx diff <old> <new>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants