fix: handle empty keys #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
approved these changes
Apr 6, 2020
| defer func() { | ||
| for i := 0; i < nDHTs; i++ { | ||
| dhts[i].Close() | ||
| defer dhts[i].host.Close() |
There was a problem hiding this comment.
the need for this defer seems like a bit of black magic, no? is there a reason the hosts need to all be closed after the dhts?
There was a problem hiding this comment.
Maybe? I really don't know. I'm just copying other tests.
| ctx, cancel := context.WithCancel(context.Background()) | ||
| defer cancel() | ||
|
|
||
| nDHTs := 2 |
There was a problem hiding this comment.
Worth having a function parameterized on this and then run the test with a 2 node and a >2 node instance?
There was a problem hiding this comment.
Probably not. This test just cares about having at least one other node so the routing table isn't empty.
Handle empty keys, both when sent in RPC requests and in the local API.
Stebalien
force-pushed
the
fix/handle-empty-keys
branch
from
3ec5dd9
to
c45167c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle empty keys, both when sent in RPC requests and in the local API.