Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect error handling during provider record lookups #554

Merged
merged 1 commit into from
Apr 6, 2020
Merged

fix incorrect error handling during provider record lookups #554

merged 1 commit into from
Apr 6, 2020

Conversation

aschmahmann
Copy link
Contributor

@aschmahmann aschmahmann commented Apr 6, 2020 •
edited
Loading

🤦‍♂

@Stebalien do we want a unit test here that just checks that we don't panic when doing a FindProviders with an empty routing table, or not worth it?

@Stebalien
Copy link
Member

Yes, but we can add it tomorrow.

@Stebalien Stebalien merged commit 4a4e60e into master Apr 6, 2020
@Stebalien Stebalien mentioned this pull request Apr 6, 2020
Open
@Stebalien
Copy link
Member

#555

@aschmahmann aschmahmann mentioned this pull request Apr 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aschmahmann @Stebalien