Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix and simplify some bootstrapping logic #405

Merged
merged 10 commits into from
Nov 6, 2019
Merged

fix and simplify some bootstrapping logic #405

merged 10 commits into from
Nov 6, 2019

Commits on Nov 5, 2019

  1. feat(bootstrap): simplify bootstrapping 

    * Rename triggerAutoBootstrap to autoBootstrap. This variable used to control
_triggering_ only but now completely disables automatic bootstrapping.
* Remove the BootstrapConfig. We introduced this before we switched to
functional options. Now that we're breaking the interfaces anyways, we might as
well use functional options all the way (easier to extend).
* Always query self (feedback from @raulk).
* Important: don't abort the bootstrap process if we timeout finding ourselves.
    @Stebalien
    Stebalien committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    ed244cd View commit details
    Browse the repository at this point in the history

  2. fix(bootstrap): bootstrap sequentially 

    The default timeout is 10s so this won't take that long anyways. On the
other hand, if we do this all at once, we max the swarms dial queue.
    @Stebalien
    Stebalien committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    645ba5b View commit details
    Browse the repository at this point in the history

  3. fix(bootstrap): don't bootstrap more than 16 buckets 

    We can't generate target IDs in buckets beyond bucket 15 so there's no point.
    @Stebalien
    Stebalien committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    71c05a8 View commit details
    Browse the repository at this point in the history

  4. chore: rename bootstrap to refresh 

    As pointed out by raul, bootstrapping and refreshing are not the same thing.
Bootstrapping is the initial setup (i.e., connect to some initial nodes to get
started). Refreshing is the process of refreshing the routing table.
    @Stebalien
    Stebalien committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    ef31967 View commit details
    Browse the repository at this point in the history

  5. fix(bootstrap): use the correct context

    @Stebalien
    Stebalien committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    4eaf429 View commit details
    Browse the repository at this point in the history

  6. chore(bootstrap): reduce indent level

    @Stebalien
    Stebalien committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    76f388b View commit details
    Browse the repository at this point in the history

  7. chore(bootstrap): rename scanInterval to refreshTicker

    @Stebalien
    Stebalien committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    b8eb083 View commit details
    Browse the repository at this point in the history

  8. fix(bootstrap): include the error in the bootstrap failure warning

    @Stebalien
    Stebalien committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    8e9ecdb View commit details
    Browse the repository at this point in the history

  9. doc(bootstrap): document minRTRefreshThreshold

    @Stebalien
    Stebalien committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    4bc0480 View commit details
    Browse the repository at this point in the history

  10. inline struct for RoutingTable config.

    @raulk
    raulk committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    a33b0b9 View commit details
    Browse the repository at this point in the history