UTF-8 Issue with latest Protobuf version

[jvsteiner]

Hi, I have a small demo project for go-libp2p-examples that I am working on, but I am getting the following error from this library (at commit 0073e12019dfda0816c596ca03bd915e4b849d21):

09:46:42.106  INFO        dht: error writing message, trying again:  proto: invalid UTF-8 string dht_net.go:271
09:46:42.106  INFO        dht: error writing message, bailing:  proto: invalid UTF-8 string dht_net.go:268
09:46:42.107  INFO        dht: error writing message, trying again:  proto: invalid UTF-8 string dht_net.go:271
09:46:42.107  INFO        dht: error writing message, bailing:  proto: invalid UTF-8 string dht_net.go:268
09:46:42.107 WARNI        dht: Multiple errors: proto: invalid UTF-8 string, proto: invalid UTF-8 string dht_bootstrap.go:122

I believe this might have something to do with a bug fixed recently over at the go protobuf implementation: issue here

basically, go-protobuf didn't enforce strings must be UTF, new versions do, and my theory is that something in this implementation sends a non-UTF string, somewhere in a protobuf during bootstrapping.

I have protobuf v3.6.0 installed.

[jvsteiner]

some simple investigation reveals DHT keys, though typed as string, contain unprintable characters at a minimum, and are probably just arbitrary bytes - seems like actual bytes type might be a better choice in the .proto - dunno if this is a viable approach...

[Stebalien]

Yeah, we should probably change this. However, we want to use string in go because go strings are just immutable byte slices. I believe there is a way to specify the "go" type but I can't remember how.

[jvsteiner]

I dont know of such an option, but then, that doesn't mean much. I get why you'd want to use a string, but not sure it's possible...

[Harrywang55666]

Protobuf with version: v1.0.0 revision: 1adfc126b41513cc696b209667c8656ea7aac67c is OK.

[gfanton]

Hello, Is there a way to hotfix this without changing the protobuf version?