This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
return the full address from conn.RemoteMultiaddr #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
feat/addr-handling
branch
from
aa51db5
to
9e6dd2b
Compare
|
test failure: |
vyzo
reviewed
Sep 18, 2019
Use ma.SplitFunc instead of splitting the entire multiaddr and comparing bytes. This avoids a bunch of unnecessary allocation and copying.
There's no reason _not_ to do this.
Stebalien
force-pushed
the
feat/addr-handling
branch
from
147eb33
to
9fde889
Compare
vyzo
approved these changes
Sep 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't think of a good reason not to do this (see libp2p/go-libp2p#723). I thought there was one but I can't remember what it was.
This also changes how we parse addresses to use
ma.SplitFunc, avoiding some allocations.