Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWX-38345: Put empty string check in volumeName while collecting the volumes for enumerate call in GetPodVolumes. #1818

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

diptiranjanpx
Copy link
Contributor

@diptiranjanpx diptiranjanpx commented Jul 29, 2024

Signed-Off-By: Diptiranjan

What type of PR is this?

bug

What this PR does / why we need it:
In GetPodVolumes while creating volume names list for the enumerateVolumes api call, we have to consider only the pod volumes which has PVC and are not WFFC.

Does this PR change a user-facing CRD or CLI?:
no

Is a release note needed?:
yes

Issue: Stong hyper convergence for pods was not working  if pods have projected volumes.
User Impact: Pods remain in pending state while using `stork.libopenstorage.org/preferLocalNodeOnly` for strong hyperconvergence.
Resolution: Pods will get scheduled in the node where volume replica lies with`stork.libopenstorage.org/preferLocalNodeOnly` annotation.

Does this change need to be cherry-picked to a release branch?:
yes, 24.2.5

Test:
Tested with strong hyperconvergence with annotation preferLocalNodeOnly and updated the ticket with the results.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.07%. Comparing base (c81f52d) to head (6bbe412).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1818   +/-   ##
=======================================
  Coverage   38.07%   38.07%           
=======================================
  Files          51       51           
  Lines       11477    11477           
=======================================
  Hits         4370     4370           
+ Misses       6714     6713    -1     
- Partials      393      394    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…volumes for enumerate call in GetPodVolumes.

           Added UTs.
@strivedi-px strivedi-px merged commit db52d37 into master Jul 30, 2024
5 checks passed
strivedi-px pushed a commit that referenced this pull request Jul 30, 2024
strivedi-px pushed a commit that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants