pwx-37435 | fix: update the snapshotschedule post adding default reclaim policy #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strivedi-px
added
the
failing-test
strivedi-px
force-pushed
the
fix-snapshot-owner-ref-bug
branch
from
201e8df
to
b19b36d
Compare
diptiranjanpx
added
bug
and removed
failing-test
strivedi-px
changed the title
diptiranjanpx
approved these changes
May 27, 2024
strivedi-px
added a commit
that referenced
this pull request
May 27, 2024
…aim policy (#1784) * fix: update the snapshotschedule post adding default reclaim policy
strivedi-px
added a commit
that referenced
this pull request
May 28, 2024
…aim policy (#1784) * fix: update the snapshotschedule post adding default reclaim policy
shkumari-px
pushed a commit
that referenced
this pull request
May 31, 2024
…aim policy (#1784) * fix: update the snapshotschedule post adding default reclaim policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it
In the
startVolumeSnapshotfunction, we were fetching the latest copy of thesnapshotschedulefrom the CR however in thehandle()function which actually calls thestartVolumeSnapshot()function, we were not persisting the updated defaultreclaimPolicytoDeletein the CR. Due to this, theownerReferencewasn't getting added to thevolumeSnapshotresource. This PR adds the change to persist the changed defaultreclaimPolicyto the CR as soon as it's updated in the object.Does this PR change a user-facing CRD or CLI?:
No
Is a release note needed?:
No
Does this change need to be cherry-picked to a release branch?:
Yes,
release-24.2.0branch.Test run
snapshot-k8s-newpipeline: https://jenkins.pwx.dev.purestorage.com/job/Users/job/strivedi/job/snapshot-k8s-new/13/consolesnapshot-csipipeline: https://jenkins.pwx.dev.purestorage.com/job/Users/job/strivedi/job/snapshot-csi/1/console