Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pwx-37435 | fix: update the snapshotschedule post adding default reclaim policy #1784

Merged
merged 3 commits into from
May 27, 2024

Conversation

strivedi-px
Copy link
Collaborator

@strivedi-px strivedi-px commented May 25, 2024

What type of PR is this?

failing test

What this PR does / why we need it
In the startVolumeSnapshot function, we were fetching the latest copy of the snapshotschedule from the CR however in the handle() function which actually calls the startVolumeSnapshot() function, we were not persisting the updated default reclaimPolicy to Delete in the CR. Due to this, the ownerReference wasn't getting added to the volumeSnapshot resource. This PR adds the change to persist the changed default reclaimPolicy to the CR as soon as it's updated in the object.

Does this PR change a user-facing CRD or CLI?:
No

Is a release note needed?:
No

Does this change need to be cherry-picked to a release branch?:
Yes, release-24.2.0 branch.

Test run

@strivedi-px strivedi-px added the failing-test The change aims at fixing an existing failing test label May 25, 2024
@diptiranjanpx diptiranjanpx added bug and removed failing-test The change aims at fixing an existing failing test labels May 26, 2024
@strivedi-px strivedi-px changed the title fix: update the snapshotschedule post adding default reclaim policy pwx-37435 | fix: update the snapshotschedule post adding default reclaim policy May 26, 2024
@strivedi-px strivedi-px merged commit 0dfb503 into master May 27, 2024
5 checks passed
strivedi-px added a commit that referenced this pull request May 27, 2024
…aim policy (#1784)

* fix: update the snapshotschedule post adding default reclaim policy
strivedi-px added a commit that referenced this pull request May 28, 2024
…aim policy (#1784)

* fix: update the snapshotschedule post adding default reclaim policy
shkumari-px pushed a commit that referenced this pull request May 31, 2024
…aim policy (#1784)

* fix: update the snapshotschedule post adding default reclaim policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants