Pb 4872:Added code to pass the storageclass value as label in the dataexport CR. #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siva-portworx
requested review from
adityadani,
lalat-das,
diptiranjanpx,
prashanthpx,
px-kesavan and
vsundarraj-px
|
Can one of the admins verify this patch? |
dbinnal-px
approved these changes
Nov 23, 2023
siva-portworx
force-pushed
the
pb-4872
branch
from
1e0672d
to
9bacacf
Compare
prashanthpx
approved these changes
Nov 23, 2023
|
Since this fix is blocking customer release, force merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Does this PR change a user-facing CRD or CLI?:
no
Is a release note needed?:
no. This change does not affect the functionality that customer use.
Does this change need to be cherry-picked to a release branch?:
23.9.1 branch