[PWX-34991] Fetching rules from migration namespace instead of namespace to migrate #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
diptiranjanpx
approved these changes
Nov 20, 2023
olavangad-px
force-pushed
the
PWX-34991
branch
from
ca1a627
to
91657e1
Compare
pp511
requested changes
Nov 20, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1569 +/- ##
==========================================
+ Coverage 66.53% 67.49% +0.96%
==========================================
Files 43 43
Lines 5453 5636 +183
==========================================
+ Hits 3628 3804 +176
+ Misses 1491 1490 -1
- Partials 334 342 +8 ☔ View full report in Codecov by Sentry. |
olavangad-px
force-pushed
the
PWX-34991
branch
from
864e52b
to
cacb1b4
Compare
pp511
reviewed
Nov 21, 2023
diptiranjanpx
approved these changes
Nov 21, 2023
olavangad-px
force-pushed
the
PWX-34991
branch
from
2668539
to
a42fc78
Compare
olavangad-px
force-pushed
the
PWX-34991
branch
from
a42fc78
to
9d080be
Compare
olavangad-px
force-pushed
the
PWX-34991
branch
from
8e7566b
to
8e253ae
Compare
olavangad-px
force-pushed
the
PWX-34991
branch
from
9149cfc
to
848344d
Compare
olavangad-px
added a commit
that referenced
this pull request
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
As part of existing code, when users create migrationschedule and clusterpair in the admin namespace, they have to create preExec and postExec rules in both the admin Namespace as well as the namespaces to be migrated.
We fix this inconvenience by fetching the rules from adminNamespace only.
Does this PR change a user-facing CRD or CLI?:
No
Is a release note needed?:
Yes, TBD
Does this change need to be cherry-picked to a release branch?:
Yes, 23.11.0
Testing Details
Have tested the changes in a local cluster and verified the bug as well as the fix.
Validated the fix by creating the migrationSchedule in the admin namespace and migrating default namespace. For this case the rules had to be created in the admin namespace.