Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWX-34991] Fetching rules from migration namespace instead of namespace to migrate #1569

Merged
merged 6 commits into from
Nov 23, 2023

Conversation

olavangad-px
Copy link
Contributor

@olavangad-px olavangad-px commented Nov 20, 2023

What type of PR is this?

bug

What this PR does / why we need it:
As part of existing code, when users create migrationschedule and clusterpair in the admin namespace, they have to create preExec and postExec rules in both the admin Namespace as well as the namespaces to be migrated.
We fix this inconvenience by fetching the rules from adminNamespace only.

Does this PR change a user-facing CRD or CLI?:
No

Is a release note needed?:
Yes, TBD

Does this change need to be cherry-picked to a release branch?:
Yes, 23.11.0

Testing Details
Have tested the changes in a local cluster and verified the bug as well as the fix.
Validated the fix by creating the migrationSchedule in the admin namespace and migrating default namespace. For this case the rules had to be created in the admin namespace.

@cnbu-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

pkg/migration/controllers/migration.go Outdated Show resolved Hide resolved
pkg/migration/controllers/migration.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (893e326) 66.53% compared to head (848344d) 67.49%.
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1569      +/-   ##
==========================================
+ Coverage   66.53%   67.49%   +0.96%     
==========================================
  Files          43       43              
  Lines        5453     5636     +183     
==========================================
+ Hits         3628     3804     +176     
+ Misses       1491     1490       -1     
- Partials      334      342       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pp511 pp511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@olavangad-px olavangad-px merged commit 4794e40 into master Nov 23, 2023
7 checks passed
olavangad-px added a commit that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants