PWX-33887: storkctl to support namespacemapping during applicationrestore creation. #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptiranjanpx
requested review from
adityadani,
pp511,
siva-portworx and
olavangad-px
|
Can one of the admins verify this patch? |
pp511
reviewed
Oct 27, 2023
Comment on lines
+256
to
+259
| cmdArgs := []string{"create", "apprestores", "-n", "test", "restore1", "--backupLocation", "backuplocation1", "--backupName", "backup1", "--namespaceMapping", "namespace1:namespace2"} | ||
| expected := "ApplicationRestore restore1 started successfully\n" | ||
| testCommon(t, cmdArgs, nil, expected, false) | ||
|
|
There was a problem hiding this comment.
We can enhance this test to pass comma separated 2 namespaces so we cover all the bases.
pp511
approved these changes
Oct 27, 2023
diptiranjanpx
force-pushed
the
PWX-33887
branch
from
a951856
to
643ceb7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1545 +/- ##
==========================================
+ Coverage 66.14% 66.23% +0.09%
==========================================
Files 43 43
Lines 5390 5405 +15
==========================================
+ Hits 3565 3580 +15
Misses 1491 1491
Partials 334 334
☔ View full report in Codecov by Sentry. |
siva-portworx
approved these changes
Oct 30, 2023
| nsMapping := strings.Split(inputMapping, ":") | ||
| if len(nsMapping) == 2 { | ||
| inputMappingMap[nsMapping[0]] = nsMapping[1] | ||
| } |
There was a problem hiding this comment.
Do we need to print any errormsg, if the namespace entry was not in the form x:y?
diptiranjanpx
force-pushed
the
PWX-33887
branch
from
643ceb7
to
9252279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-Off-By: Diptiranjan
What type of PR is this?
What this PR does / why we need it:
Added the param for creating applicationrestore with namespacemapping with storkctl.
Does this PR change a user-facing CRD or CLI?:
Is a release note needed?:
Does this change need to be cherry-picked to a release branch?:
Test
updated in ticket PWX-33887.