PWX-30276: Do not delete pods running on storage down nodes. #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1385 +/- ##
==========================================
+ Coverage 67.76% 67.82% +0.06%
==========================================
Files 42 42
Lines 4889 4889
==========================================
+ Hits 3313 3316 +3
+ Misses 1242 1240 -2
+ Partials 334 333 -1
☔ View full report in Codecov by Sentry. |
pp511
reviewed
May 1, 2023
pp511
reviewed
May 1, 2023
pp511
reviewed
May 1, 2023
pp511
reviewed
May 1, 2023
pp511
reviewed
May 1, 2023
pp511
requested changes
May 1, 2023
pp511
approved these changes
May 3, 2023
|
Thanks @pp511 ! Will fix the missed comment. Currently trying to get a successful integration test run with the newly added tests. Will merge it once I get a success. |
adityadani
force-pushed
the
PWX-30726
branch
2 times, most recently
from
7f6c49d
to
f142f33
Compare
- Introduce a new state in Stork for storage down nodes. - Remap portworx StorageDown state to Stork's StorageDown state - For degraded node state: - filter out the nodes from extender requests. - monitor should delete the pods running on them - For storage down state: - do not filter out such nodes. - give a low score to nodes which are storage down. - monitor should not delete pods running on them Signed-off-by: Aditya Dani <aditya@portworx.com>
pp511
reviewed
May 8, 2023
| require.NotEqual(t, poolMaintenanceNode.Name, scheduledNodes[0].Name, "Pod should not be scheduled on node in PoolMaintenance state") | ||
|
|
||
| err = volumeDriver.ExitPoolMaintenance(poolMaintenanceNode) | ||
| require.NoError(t, err, "Error starting driver on Node %+v", scheduledNodes[0]) |
There was a problem hiding this comment.
nit..Error exiting pool maintenance
pp511
reviewed
May 8, 2023
| verifyScheduledNode(t, scheduledNodes[0], volumeNames) | ||
|
|
||
| err = volumeDriver.EnterPoolMaintenance(scheduledNodes[0]) | ||
| require.NoError(t, err, "Error stopping driver on scheduled Node %+v", scheduledNodes[0]) |
There was a problem hiding this comment.
Nit..Error stopping driver -> Error entering pool maintenance
|
Integration tests look good. Just two nits that need to be addressed |
- Added integration tests for extender and health-monitor. - Simulating a StorageDown state by using Portworx driver's Pool Maintenance operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Does this PR change a user-facing CRD or CLI?:
No
Is a release note needed?:
Does this change need to be cherry-picked to a release branch?:
Yes - 23.4
Testing Notes