Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWX-30356: Storkctl create clusterpair doesn't honor port from cli #1383

Conversation

pp511
Copy link
Contributor

@pp511 pp511 commented Apr 28, 2023

What type of PR is this?

bug

What this PR does / why we need it:
Storkctl create clusterpair doesn't honor port from cli
https://portworx.atlassian.net/browse/PWX-30356

Does this PR change a user-facing CRD or CLI?:
yes

Is a release note needed?:

Issue: Storkctl create clusterpair doesn't honor the port provided from CLI
User Impact: Users unable to create bi-directional clusterpairs
Resolution: Passing the port provided from CLI in the endpoints for creating cluster pair.

Does this change need to be cherry-picked to a release branch?:
yes 23.5

Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
@cnbu-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (b5dc9a0) 67.80% compared to head (c7dae25) 67.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1383      +/-   ##
==========================================
+ Coverage   67.80%   67.82%   +0.01%     
==========================================
  Files          42       42              
  Lines        4886     4889       +3     
==========================================
+ Hits         3313     3316       +3     
- Misses       1239     1240       +1     
+ Partials      334      333       -1     
Impacted Files Coverage Δ
pkg/storkctl/clusterpair.go 22.52% <0.00%> (-0.21%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
@pp511 pp511 merged commit 2a02115 into master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants