PWX-30291: Removing sts and deployments from stork webhook #1373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Remove Stork as the scheduler from Statefulsets and Deployments.
Currently we are not able to set Stork as the scheduler for Statefulsets because we rely on the PVC to be owned by Portworx. STS uses volumeClaimTemplates where PVC is not created when the webhook admission request comes to stork and schedulerName is not updated. Later when webhook admission request arrives for Pods, Stork does update the Schedulername and it works.
I believe there is no reason to update Stork as the scheduler for StatefulSets and Deployments when we have the webhook enabled for Pods. This PR is removing these webhook for Deployments and Statefulsets.
Please note that any annotation set on the Deployment or STS is not passed onto the Pods. To be able to specify stork.libopenstorage.org/disable-admission-controller that disables webhook for the specific STS /Deployment, we need to update it on spec.templace.metadata.annotations.
Does this PR change a user-facing CRD or CLI?:
no
Is a release note needed?:
Does this change need to be cherry-picked to a release branch?:
yes 23.5