Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWX-38344] Ability to configure limits, requests and placement constraints for components deployed by operator #1649

Open
wants to merge 2 commits into
base: release-24.2.0
Choose a base branch
from

Conversation

sshreyas-px
Copy link
Collaborator

Signed-off-by: Piyush Nimbalkar pnimbalkar@purestorage.com

PWX-38500 Resources and placement support CSI and Portworx API

Signed-off-by: Piyush Nimbalkar pnimbalkar@purestorage.com

PWX-38500 Custom annotation support for CSI, Portworx API, KVDB

Signed-off-by: Piyush Nimbalkar pnimbalkar@purestorage.com

PWX-38415 Fix resources comparison when resources is reset in STC

Signed-off-by: Piyush Nimbalkar pnimbalkar@purestorage.com

PWX-38379 change pool and volume resize alerts from warning to info

Docs PR: https://github.com/pure-px/portworx-documentation/pull/977

PWX-38500 Add UTs for resources, annotation and placement changes

Signed-off-by: Piyush Nimbalkar pnimbalkar@purestorage.com

Create a new 24.1.2-drw release

What this PR does / why we need it:

Which issue(s) this PR fixes (optional)
Closes #

Special notes for your reviewer:

Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com>

PWX-38500 Resources and placement support CSI and Portworx API

Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com>

PWX-38500 Custom annotation support for CSI, Portworx API, KVDB

Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com>

PWX-38415 Fix resources comparison when resources is reset in STC

Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com>

PWX-38379 change pool and volume resize alerts from warning to info

Docs PR: https://github.com/pure-px/portworx-documentation/pull/977

PWX-38500 Add UTs for resources, annotation and placement changes

Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com>

Create a new 24.1.2-drw release
@sshreyas-px sshreyas-px force-pushed the sshreyas/feature_drw_res_limits branch 2 times, most recently from 471d49e to 4d38aa5 Compare August 19, 2024 15:26
@sshreyas-px sshreyas-px force-pushed the sshreyas/feature_drw_res_limits branch from 4d38aa5 to cbc7f9d Compare August 19, 2024 15:37
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 76.71756% with 61 lines in your changes missing coverage. Please review.

Project coverage is 79.72%. Comparing base (30ed9ab) to head (cbc7f9d).

Files Patch % Lines
pkg/util/util.go 0.00% 31 Missing ⚠️
drivers/storage/portworx/component/csi.go 90.07% 9 Missing and 4 partials ⚠️
pkg/controller/storagenode/storagenode.go 66.66% 5 Missing and 3 partials ⚠️
pkg/util/k8s/k8s.go 0.00% 7 Missing ⚠️
drivers/storage/portworx/component/portworx_api.go 95.74% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release-24.2.0    #1649      +/-   ##
==================================================
- Coverage           79.79%   79.72%   -0.07%     
==================================================
  Files                  61       61              
  Lines               18831    18913      +82     
==================================================
+ Hits                15026    15079      +53     
- Misses               2715     2745      +30     
+ Partials             1090     1089       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikita-bhatia
Copy link
Contributor

@sshreyas-px can you please add details in description about

  • what is the PR about? What are we trying to add here?
  • What testing has been performed and on what platform?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants