PWX-38583 : fix nil pointer derefernce in operator pod #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-24.2.0 #1643 +/- ##
===============================================
Coverage 79.79% 79.79%
===============================================
Files 61 61
Lines 18833 18833
===============================================
Hits 15028 15028
Misses 2715 2715
Partials 1090 1090 ☔ View full report in Codecov by Sentry. |
svijaykumar-px
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Operator pod crashes with nil pointer dereference error while upgrading PX from 3.1.1 to 3.1.2
because, cluster.Spec.UpdateStrategy.RollingUpdate.Disruption.Allow, becuase when Allow is *bool and the value was not set, it was nil and trying to dereference a nil pointer resulted in a nil pointer dereference error.
As a fix, changed Allow bool instead of *bool, since the value can be either true/false.
Which issue(s) this PR fixes (optional)
Closes # https://purestorage.atlassian.net/browse/PWX-38583
Special notes for your reviewer:
Verified on vanilla k8s