Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] PWX-36509 : StorageCluster schema changes to support parallel portworx upgrades #1576

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

hitesh-wani-px
Copy link
Collaborator

What this PR does / why we need it:
This PR will add a new field to control the PX upgrade behavior. The default behavior would be to have a non-disruptive upgrade. But users should be able to disable that and go back to the old behavior of upgrading nodes in parallel without worrying about the disruption.

Which issue(s) this PR fixes (optional)
Closes # https://purestorage.atlassian.net/browse/PWX-36509

Signed-off-by: hitesh-wani-px <hwani+github@purestorage.com>
Signed-off-by: hitesh-wani-px <hwani+github@purestorage.com>
Copy link

This PR is stale because it has been in review for 3 days with no activity.

Copy link
Contributor

@svijaykumar-px svijaykumar-px left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hitesh-wani-px hitesh-wani-px merged commit ef99677 into PWX-25414-24.2.0 Jul 15, 2024
9 checks passed
nikita-bhatia added a commit that referenced this pull request Aug 12, 2024
* [Cherry-pick into feature]: Cherry-pick of all tickets related to Smart and parallel upgrades merged into master (#1578)

* adding k8snode name label to px pods

* correcting go fmt error

* making requested changes

* Creating node PDB

* go fmt error

* Checking node version instead of cluster

* making requested changes

Conflicts:
	drivers/storage/portworx/component/disruption_budget.go

* aggregating errors

* adding logic to delete node PDB

* correcting go fmt errors

* made requested changes

* correcting after merge conflict

* [cherry-pick] PWX-36509 : StorageCluster schema changes to support parallel portworx upgrades (#1576)

* StorageCluster schema changes to support parallel portworx upgrades

Signed-off-by: hitesh-wani-px <hwani+github@purestorage.com>

* change DisruptionSpec to Disruption and its description

Signed-off-by: hitesh-wani-px <hwani+github@purestorage.com>

---------

Signed-off-by: hitesh-wani-px <hwani+github@purestorage.com>

* PWX-36477 : Updating Node PDB to allow k8s upgrades (#1580)

* vendoring openstorage with nooverlappingnodes api

* adding logic to update node PDB

* Adding UTs and correcting logic

* go fmt error

* adding logic to delete cluster pdb after 3.1.2

* addressing comments requested

* skip checking node version if version is empty

* passing nodeIds instead of name to API

* making requested changes and adding UTs

* changing log to info

* PWX-36510: No disruption of volumes for portworx upgrades (#1612)

* non disruptive portworx upgrades

* adding new method to driver interface

* correcting UT

* goimport fmt

* gofmt file

* update PX version in test

* correcting new testcases

---------

Signed-off-by: hitesh-wani-px <hwani+github@purestorage.com>
Co-authored-by: Swarupa Vijaykumar <123443458+svijaykumar-px@users.noreply.github.com>
Co-authored-by: hitesh-wani-px <hwani+github@purestorage.com>
Co-authored-by: svijaykumar-px <svijaykumar@purestorage.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants