remotes: support anonymous remotes #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmrowla
commented
Jul 25, 2023
Comment on lines
+347
to
+350
| def create_anonymous(self, url): | ||
| """Create a new anonymous (in-memory only) remote with the given URL. | ||
| Returns a <Remote> object. | ||
| """ |
There was a problem hiding this comment.
This could be done in the existing create() by checking something like
if not name:
C.git_remote_create_anonymous()
but I wasn't sure if that would be explicit enough since create(None, url) could also imply that the user intended to make a libgit2 detached remote instead of an anonymous one. (Or we could also do it with create(None, url, anonymous=True))
Adding the separate method seemed like the cleanest solution to me, but I don't have a problem with changing it to one of the alternatives if you'd prefer.
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Nov 5, 2023
1.13.2 (2023-10-30) ------------------------- - Support Python 3.12 - Documentation updates `#1242 <https://github.com/libgit2/pygit2/pull/1242>`_ 1.13.1 (2023-09-24) ------------------------- - Fix crash in reference rename `#1233 <https://github.com/libgit2/pygit2/issues/1233>`_ 1.13.0 (2023-09-07) ------------------------- - Upgrade to libgit2 v1.7.1 - Don't distribute wheels for pypy, only universal wheels for macOS - New ``Repository.remotes.create_anonymous(url)`` `#1229 <https://github.com/libgit2/pygit2/pull/1229>`_ - docs: update links to pypi, pygit2.org `#1228 <https://github.com/libgit2/pygit2/pull/1228>`_ - Prep work for Python 3.12 (not yet supported) `#1223 <https://github.com/libgit2/pygit2/pull/1223>`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
git_remote_create_anonymousfor creating anonymous (in-memory) remotes when you have a URL but do not want to create a named remote and the associated config entries