DRY delta types #581
Merged
DRY delta types #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return (GTDeltaType)self.git_diff_delta.status; | ||
| } | ||
|
|
||
| - (double)similarity { |
There was a problem hiding this comment.
That's 87c6b2a, so no, it's willingly present.
There was a problem hiding this comment.
I may or may not have forgotten adding the @property 😟 .
There was a problem hiding this comment.
Rebased with fixup, sorry about that.
tiennou
force-pushed
the
dry-delta-types
branch
from
87c6b2a
to
fa21ded
Compare
tiennou
force-pushed
the
dry-delta-types
branch
from
fa21ded
to
f7a846e
Compare
|
Thanks 🍝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge the 2 definitions we have of the
GIT_DELTA_*enumeration, because I found them to be out of sync. Bikeshedding welcome on the name, but I can't think of something better that wouldn't be specific to one case or the other...