Make GTCredential from GTCredentialProviderBlock optional #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We've only been adding the _Nullable annotations to the .h files as that's the only place I think they are required. Not sure which is the better practice. I like that you use the newer _Nullable. It's probably time to change the rest of the uses of the old nullable annotation, but that can be done in another PR. |
|
Ok, that's fixed. |
Merged
|
Nice. Not sure what happened with that one build ¯_(ツ)_/¯ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the credential is enforced as non-optional by the swift compiler.
This means that there is no way for the user to abort a remote operation that demands a credential.