GTTreeBuilder: don't add blob data lazily #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't add the blob data lazily to the object database (during tree creation), which would prevent strict object validity checking from functioning. In addition, this prevents us from hashing the file twice (once to compute the OID, again when adding to the object database) and reduces memory overhead.
|
Note, of course, that I'm missing the historical context here. So I may be missing the use case that this enables. I think that in the general case, removing this is probably the right thing, but if there's value here then it could be optional instead... |
|
Seem like the initial implementation was made back in 2013 (1f203eb) but it seems to have no specific reason to write the data to the This also fixes the test for the Thanks so much for sorting this out! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the blob data to the object database immediately in
[GTTreeBuilder addEntryWithData], instead of queueing it up. This enables strict object validity checking, prevents us from hashing the file twice (once to compute the OID to give toaddEntryWithOID, and again when adding to the object database) and reduces memory overhead.