Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix super slow iOS Tests #555

Merged
merged 7 commits into from
Feb 26, 2016
Merged

Fix super slow iOS Tests #555

merged 7 commits into from
Feb 26, 2016

Conversation

pietbrauer
Copy link
Member

Updates dependencies to Nimble, Quick and SSZipArchive.

iOS Tests were running super slow (30 minutes total) this was because after every single test case the unzipped fixture repository would be deleted from disk and unzipped again from the 28MB big zip file. This was not an issue on Mac as unzip super fast (apparently) but SSZipArchive cannot quite keep up and so every single iOS test case would take 5-7 seconds to unzip + the time the test needs to run.

What I did is just unzip it once and store it in a directory called clean_repository, the directory is still removed after each test but instead of unzipping again I just copy the desired repository into its place not touching the clean_repository.

@pietbrauer
Copy link
Member Author

ITS GREEEN!!!!

Due to the Quick Update I had to set the deployment target of the Tests to iOS 9.0 which does not affect the framework itself.

A nice side effect of the Quick Update is that test names are now actually readable. ✌️

@phatblat
Copy link
Member

This is amazingly faster. Nice work!

Had one snag when running carthage bootstrap:

A shell task failed with exit code 74:
xcodebuild: error: Unable to read project 'SSZipArchive.xcodeproj' from folder '/Users/phatblat/dev/libgit2/objective-git/Carthage/Checkouts/ZipArchive'.
    Reason: Project /Users/phatblat/dev/libgit2/objective-git/Carthage/Checkouts/ZipArchive/SSZipArchive.xcodeproj cannot be opened because it is missing its project.pbxproj file.

It looks like checking out the v1.0.1 tag left an empty SSZipArchive.xcodeproj folder since there is no project.pbxproj in the tree at that tag.

This was due to having an older ZipArchive checkout which left behind the .xcodeproj folder and confused carthage and xcodebuild.

@phatblat
Copy link
Member

One little nitpick, there's now a dead workspace reference to the SSZipArchive project.

screen shot 2016-02-25 at 8 26 33 pm

@pietbrauer
Copy link
Member Author

Yeah, SSZipArchive is a bit weird but we use the files directly.

@pietbrauer
Copy link
Member Author

Will remove the file reference.

@phatblat
Copy link
Member

Looks like v1.1 has framework targets now, but that can be updated in another PR.

@pietbrauer
Copy link
Member Author

Updated SSZipArchive v1.1 and fixed the reference.

@pietbrauer
Copy link
Member Author

Can't update to 1.1 because it has a lot of warnings. Staying on 1.0.1 but remove the reference to the project.

@phatblat
Copy link
Member

Sounds good to me!

phatblat added a commit that referenced this pull request Feb 26, 2016
@phatblat phatblat merged commit c0c4188 into master Feb 26, 2016
@pietbrauer pietbrauer deleted the piet/update-nimble-quick branch February 26, 2016 04:19
@pietbrauer pietbrauer mentioned this pull request Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants