Added note setup step #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to manually add a header search path as per libgit2#441 in order to compile. Added that as a step to the instructions. Only tested on iOS so added to end of that list. Not sure if it also applies for Mac targets (assuming so). If so, please feel free to move to the top where it might make more sense and apply to both.
|
Thanks! I forgot about this step. |
phatblat
added a commit
that referenced
this pull request
Oct 20, 2015
Added "Header Search Paths" step to Carthage instructions
|
No worries ;) And thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to manually add a header search path as per #441 in order to compile. Added that as a step to the instructions. Only tested on iOS so added to end of that list. Not sure if it also applies for Mac targets (assuming so). If so, please feel free to move to the top where it might make more sense and apply to both.