Update submodule ignore rule API #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! Note that I had to apply #475 in order to get this branch or master to build successfully. Have you been having any issues with the new libgit2 dependency on libcurl? |
Oddly no 😢 |
|
Sorry, I forgot about this PR. Is it ready to merge? |
|
Yup, it's ready! |
phatblat
pushed a commit
that referenced
this pull request
Jul 18, 2015
Update submodule ignore rule API
|
👯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us back the flexibility that we lost when I bumped libgit2 in #472. Namely, we couldn't get the submodule status using an ignore rule without also saving the ignore rule to disk.