Add modulemap file to iOS target #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't build the iOS target with or without these changes, but this looks legit to me. |
|
There is no CI for iOS right? |
|
CI only works for collaborators, but yeah—there are no iOS tests, partly due to the ridiculous build times. |
|
Anyways, I agree that this is legit. 👍 |
jspahrsummers
added a commit
that referenced
this pull request
Jan 21, 2015
Add modulemap file to iOS target
|
I see. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #436 adding a module map file in iOS is required as it is in OS X.