Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Tests to Specs. #292

Merged
merged 39 commits into from
Nov 18, 2013
Merged

Convert Tests to Specs. #292

merged 39 commits into from
Nov 18, 2013

Commits on Nov 7, 2013

  1. Rewrite tests for GTBlob.

    @tiennou
    tiennou committed Nov 7, 2013
    Configuration menu
    Copy the full SHA
    618570b View commit details
    Browse the repository at this point in the history

  2. Use git_blob_create_fromdisk instead of going through the `fromwork… 

    …dir` version.

Because I don't want to handle the pain of relativizing the passed URL.
    @tiennou
    tiennou committed Nov 7, 2013
    Configuration menu
    Copy the full SHA
    ed0a2a8 View commit details
    Browse the repository at this point in the history

  3. Asserts.

    @tiennou
    tiennou committed Nov 7, 2013
    Configuration menu
    Copy the full SHA
    b7f671f View commit details
    Browse the repository at this point in the history

  4. Move the contents of GTBranchTest where they belong.

    @tiennou
    tiennou committed Nov 7, 2013
    Configuration menu
    Copy the full SHA
    709c2b3 View commit details
    Browse the repository at this point in the history

  5. Remove GTBranchTest. 

    I know there's still a test in here, but I'm not sure what it's testing since we're ARC now…
    @tiennou
    tiennou committed Nov 7, 2013
    Configuration menu
    Copy the full SHA
    9e69d7c View commit details
    Browse the repository at this point in the history

  6. Convert GTCommitTest to Expecta.

    @tiennou
    tiennou committed Nov 7, 2013
    Configuration menu
    Copy the full SHA
    04fd3e7 View commit details
    Browse the repository at this point in the history

  7. Convert GTReferenceTest.

    @tiennou
    tiennou committed Nov 7, 2013
    Configuration menu
    Copy the full SHA
    f578c4c View commit details
    Browse the repository at this point in the history

  8. Convert GTRepositoryTest.

    @tiennou
    tiennou committed Nov 7, 2013
    Configuration menu
    Copy the full SHA
    9c2c3e2 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2013

  1. Cleanup GTBlob's header.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    f655dec View commit details
    Browse the repository at this point in the history

  2. Make error a local variable.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    1ea8499 View commit details
    Browse the repository at this point in the history

  3. Expect errors to be nil here.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    49ed41f View commit details
    Browse the repository at this point in the history

  4. Reindent commented test.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    9b1bd6c View commit details
    Browse the repository at this point in the history

  5. Rename test.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    8346974 View commit details
    Browse the repository at this point in the history

  6. Cruft--;

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    bc98f3c View commit details
    Browse the repository at this point in the history

  7. Dot-syntaxify.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    86d4f7b View commit details
    Browse the repository at this point in the history

  8. Rename isValidReference and define it at declaration time.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    173e177 View commit details
    Browse the repository at this point in the history

  9. Make error a local variable.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    5246535 View commit details
    Browse the repository at this point in the history

  10. Fix the lookupObjectByRefspec:error: name.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    79fcc2d View commit details
    Browse the repository at this point in the history

  11. Whitespace.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    d4a1ae8 View commit details
    Browse the repository at this point in the history

  12. Test that the returned branches are the expected ones.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    e09ebb5 View commit details
    Browse the repository at this point in the history

  13. Test the complete reference array in one step.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    d07941e View commit details
    Browse the repository at this point in the history

  14. Clarify comment.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    8f47b33 View commit details
    Browse the repository at this point in the history

  15. Test the actual error domain & code.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    9bc13e2 View commit details
    Browse the repository at this point in the history

  16. Convert local file: URLs to paths before handing over to git_clone. 

    Fixes a bug where a locally-cloned remote would get a `file:` URL as it's origin URL, making the push machinery shrivel in fear.
    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    b88903d View commit details
    Browse the repository at this point in the history

  17. Dot-syntaxify.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    2b2be90 View commit details
    Browse the repository at this point in the history

  18. Use -fileSystemRepresentation here.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    8265839 View commit details
    Browse the repository at this point in the history

  19. File reference URLs are file URLs; no need for a separate test.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    bcdd927 View commit details
    Browse the repository at this point in the history

  20. Useless call; file reference URLs know how to path-ify themselves.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    aa510a6 View commit details
    Browse the repository at this point in the history

  21. Test that the remote set by +clone… looks fine to libgit2.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    7f7cb21 View commit details
    Browse the repository at this point in the history

  22. De-oneline-ify.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    2986a6b View commit details
    Browse the repository at this point in the history

  23. Make error a local.

    @tiennou
    tiennou committed Nov 9, 2013
    Configuration menu
    Copy the full SHA
    cff180a View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2013

  1. Add methods to create new bare and non-bare repositories to `GTTestCa… 

    …se`.
    @tiennou
    tiennou committed Nov 10, 2013
    Configuration menu
    Copy the full SHA
    cbe71f8 View commit details
    Browse the repository at this point in the history

  2. Test that new repos have unborn HEADs.

    @tiennou
    tiennou committed Nov 10, 2013
    Configuration menu
    Copy the full SHA
    c43cad5 View commit details
    Browse the repository at this point in the history

  3. Define expectSHAForRevspec inline.

    @tiennou
    tiennou committed Nov 10, 2013
    Configuration menu
    Copy the full SHA
    3dd9c70 View commit details
    Browse the repository at this point in the history

  4. Use the clone tests from #280.

    @tiennou
    tiennou committed Nov 10, 2013
    Configuration menu
    Copy the full SHA
    378b31d View commit details
    Browse the repository at this point in the history

  5. Put the newly-cloned repo in the test-case managed temporary directory.

    @tiennou
    tiennou committed Nov 10, 2013
    Configuration menu
    Copy the full SHA
    87efa74 View commit details
    Browse the repository at this point in the history

  6. Huh, bare clones don't checkout...

    @tiennou
    tiennou committed Nov 10, 2013
    Configuration menu
    Copy the full SHA
    87fff3b View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2013

  1. Merge branch 'master' into tests-to-specs 

    Conflicts:
	Classes/GTDiff.m
    @tiennou
    tiennou committed Nov 11, 2013
    Configuration menu
    Copy the full SHA
    c6720b3 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2013

  1. Rename …Revspec: => …RevParse:.

    @tiennou
    tiennou committed Nov 13, 2013
    Configuration menu
    Copy the full SHA
    9936d06 View commit details
    Browse the repository at this point in the history