Define git___load when building with -DTHREADSAFE=OFF
#5664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow folks that build in non-thread-safe environments to still be able to build the library. Fixes: libgit2#5663
|
Maybe we should also add a CI build that builds without threads? |
If being able to build in a non-threaded environment has value, then yeah, we should probably have a CI step that runs this. Maybe only in our nightlies because it's so rare to break something here and our matrix is already huge. |
|
Thanks @lhchavez! On a tangential note, I agree that having CI for non-threaded systems would be helpful. In addition, this file is getting a little complicated, we might want to think about how to reduce the cyclomatic complexity. 😓 |
ethomson
approved these changes
Oct 14, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow folks that build in non-thread-safe environments to
still be able to build the library.
Fixes: #5663