Single-precision STRtree #757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
reviewed
Feb 13, 2023
dbaston
force-pushed
the
float-interval
branch
from
f8b9881 to
cffc499
Compare
|
Doesn't seem worth it for 5-10%. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes
EnvelopeandIntervalto be constructed from any numeric type, and changes theIndexedPointInAreaLocatorto useInterval<float>. I tested this withGEOSPreparedContainsbecause past testing has shown this to be an area where shrinking the size of a tree node has a real benefit. And it does have an impact, but only about 10% in my testing. I'm not sure that's worth it, but maybe there's a more compelling application. Rounding a query envelope fromdoubletofloatin a strictly enlarging way seems to pretty expensive.