-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: add static configuration for setuptools-scm
#166
MNT: add static configuration for setuptools-scm
#166
Conversation
c5a9309
to
19af77e
Compare
good news, it looks like we can actually reproduce the real error on this repo now: https://github.com/liberfa/pyerfa/actions/runs/12963097535/job/36160295587 |
The build error on aarch64 is unrelated. See upstream issue at tonistiigi/binfmt#215 |
Is it also possible to clean up setup.py version stuff? Do we really need guess next version? |
Oh I missed that part. I was assuming that
Indeed we shouldn't need this. I'm guessing it was done to support building without setuptools-scm available 4 years ago (65603bd) |
19af77e
to
66f30fc
Compare
setuptools-scm
There's also a version.py but it's probably ok as is. Second pair of eyes won't hurt. Thanks! |
This looks good but as I don't remember quite why we had the fairly complicated code in |
p.s. Thanks for linking to the upstream issue with |
Dear @neutrinoceros , @pllim , @mhvk , According to my understanding you want to have
in the
from |
66f30fc
to
5e25e47
Compare
Thanks @avalentino for your quick review ! |
setuptools-scm
setuptools-scm
Thanks @neutrinoceros |
Thanks all! |
A release soon would be nice so the "exotic" job can pick it up. We don't run those jobs on dev pyerfa. |
Actually how does python3-erfa gets pushed to ubuntu-rolling? |
OK, I'm making a new release. I think the release gets into p.s. I guess the wheels built will fail for |
Hmm, the |
Hmm is it possible to opt out of aarch64 wheel for this release? |
I can help for the debian part. Once the release is ready I can quickly push the new version in debian |
Address #165