Skip to content

Commit

Permalink
Minor changes
Browse files Browse the repository at this point in the history 
Also, see issue #5
  • Loading branch information
@rocky
rocky committed Feb 5, 2017
1 parent dfd747f commit eed7848
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions lib/paranoia/paranoia.c
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/*
Copyright (C) 2004, 2005, 2006, 2008, 2011 Rocky Bernstein <rocky@gnu.org>
Copyright (C) 2004, 2005, 2006, 2008, 2011, 2017
Rocky Bernstein <rocky@gnu.org>
Copyright (C) 2014 Robert Kausch <robert.kausch@freac.org>
Copyright (C) 1998 Monty xiphmont@mit.edu
Expand Down Expand Up @@ -1019,17 +1020,16 @@ i_iterate_stage2(cdrom_paranoia_t *p,
long searchbegin=max(fbv-p->dynoverlap,rb(root));
sort_info_t *i=p->sortcache;
long j;
long best_matchbegin = -1;
long best_matchend = -1;
long best_offset = -1;

/* Initialize the "sort cache" index to allow for fast searching
* through the verified fragment between (fbv,fev). (The index will
* actually be built the first time we search.)
*/
sort_setup(i, fv(v), &fb(v), fs(v), fbv, fev);

long best_matchbegin = -1;
long best_matchend = -1;
long best_offset = -1;

/* ??? Why 23? */
for(j=searchbegin; j<searchend; j+=23){

Expand Down

5 comments on commit eed7848

@Freso
Copy link

@Freso Freso commented on eed7848 Feb 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, say I look at this commit in 20 years and GitHub is no more, so the link in the commit message (if you actually made a link and not just a literal "#5") is dead… How will I know why you made these changes? Please, please, please write better commit messages. :/

http://chris.beams.io/posts/git-commit/

@rocky
Copy link
Collaborator Author

@rocky rocky commented on eed7848 Feb 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit comment has been updated. If this is still lacking, suggest a specific change here, and I'll update the commit message.

@Freso
Copy link

@Freso Freso commented on eed7848 Feb 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't mean to suggest you should rewrite history (esp. if it's already been pushed to the master branch on GitHub!), just that it would be nice to be more careful with commit messages.

@rocky
Copy link
Collaborator Author

@rocky rocky commented on eed7848 Feb 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't in the master branch. And actually, I'm pretty careful about the commit messages. You just looked at the one out of thousands that didn't suit your liking.

And in 20 years and when github is no more I don't think anyone would have gave a damn about that particular message. It might not even make it to master.

@Freso
Copy link

@Freso Freso commented on eed7848 Feb 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Didn't mean to barge in and make a fuss. I was linked here from another project and didn't realise until later that the commit was not actually part of that project. Sorry. :)

Please sign in to comment.