ParameterMultiAccessor should store a vector of unique_ptrs #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not need to call new directly, std::unique_ptrs can be returned from functions without making a copy.
|
Looks good, and this doesn't break anything in GRINS (again, with grinsfem/grins#620 ) for me. |
|
I totally spoke too soon there - I'd built against an older libMesh install by accident. There actually is a bug here; I'll put up a separate PR with the fix. |
roystgnr
added a commit
to roystgnr/libmesh
that referenced
this pull request
May 12, 2022
This fixes the compilation error in GRINS that libMesh#3281 introduced for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another hopefully straightforward update similar to #3274, #3273, #3270. We don't have any tests (or even code that includes the header for)
ParameterMultiAccessorso strictly speaking this should be run through the GRINS regression testing before being merged, and (even more strictly speaking) we should probably add a unit test for this in libmesh.