Cleans up deprecated APIs #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR migrates spark-redshift to Spark 2.0. It is marked as WIP because it depends on databricks/spark-avro#137. Author: Cheng Lian <lian@databricks.com> Closes databricks#221 from liancheng/spark-2.0-migration.
Author: Marc-André Tremblay <marcandre.tr@gmail.com> This patch had conflicts when merged, resolved by Committer: Josh Rosen <joshrosen@databricks.com> Closes databricks#220 from marctrem/custom-jdbc-column-types.
liancheng
force-pushed
the
delete-deprecated-api
branch
from
54000ec to
77c2838
Compare
|
Closing this since the formal PR has been sent (databricks#239). |
JoshRosen
pushed a commit
to databricks/spark-redshift
that referenced
this pull request
Jul 18, 2016
This PR branch is based on #221 and contains its changes. For easier review, please refer to liancheng#1. This PR cleans up all the deprecated APIs in 1.x: - `Parameters.overwrite` Users should use `SaveMode` instead. - `SchemaParser` Removed since the only API method uses this class is removed. - `RedshiftDataFrame.saveAsRedshiftTable(parameters: Map[String, String])` Users should use `DataFrameWriter` methods instead. - `RedshiftContext.redshiftTable(parameters: Map[String, String])` Users should use `DataFrameReader` methods instead. - `RedshiftContext.redshiftFile(path: String, schema: String)` Removed since we'd like to stop using string schema parsing. The following API method is added to replace it: ```scala def redshiftFile(path: String, schema: StructType): DataFrame ``` Fixes #66. Author: Cheng Lian <lian@databricks.com> Closes #239 from liancheng/delete-deprecated-api.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR branch forks from databricks#221. A formal PR targets to databricks/spark-redshift master branch will be created after databricks#221 is merged.
This PR cleans up all the deprecated APIs in 1.x:
Parameters.overwriteUsers should use
SaveModeinstead.SchemaParserRemoved since the only API method uses this class is removed.
RedshiftDataFrame.saveAsRedshiftTable(parameters: Map[String, String])Users should use
DataFrameWritermethods instead.RedshiftContext.redshiftTable(parameters: Map[String, String])Users should use
DataFrameReadermethods instead.RedshiftContext.redshiftFile(path: String, schema: String)Removed since we'd like to stop using string schema parsing. The following API method is added to replace it: