-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make biome suppressions/unused a linting error #962
base: main
Are you sure you want to change the base?
feat: make biome suppressions/unused a linting error #962
Conversation
Co-Authored-By: hirotaka.miyagi@route06.co.jp <hirotaka.miyagi@route06.co.jp>
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
Updates to Preview Branch (devin/1742555063-biome-warning-to-error) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
Co-Authored-By: hirotaka.miyagi@route06.co.jp <hirotaka.miyagi@route06.co.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!!
…o-error feat: make biome suppressions/unused a linting error
Issue
Why is this change needed?
Currently, unused suppression comments in the codebase only generate warnings, which allows them to remain in the codebase. This PR updates the Biome configuration to make these warnings errors, ensuring they are addressed promptly.
What would you like reviewers to focus on?
--error-on-warnings
flag in all package.json files is appropriateTesting Verification
Verified that running
pnpm lint:biome
in the erd-core package now fails with an error when an unused suppression comment is present.Additional Notes
Link to Devin run: https://app.devin.ai/sessions/d7718d0da4c34b99b1e11757677a44c3