Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make biome suppressions/unused a linting error #962

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Issue

  • resolve: Biome suppressions/unused warning not treated as error

Why is this change needed?

Currently, unused suppression comments in the codebase only generate warnings, which allows them to remain in the codebase. This PR updates the Biome configuration to make these warnings errors, ensuring they are addressed promptly.

What would you like reviewers to focus on?

  • Verify that the approach of using the --error-on-warnings flag in all package.json files is appropriate
  • Confirm this will correctly catch unused suppression comments in CI

Testing Verification

Verified that running pnpm lint:biome in the erd-core package now fails with an error when an unused suppression comment is present.

Additional Notes

Link to Devin run: https://app.devin.ai/sessions/d7718d0da4c34b99b1e11757677a44c3

Co-Authored-By: hirotaka.miyagi@route06.co.jp <hirotaka.miyagi@route06.co.jp>
Copy link

changeset-bot bot commented Mar 21, 2025

⚠️ No Changeset found

Latest commit: a0e2464

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sorry, something went wrong.

Copy link

vercel bot commented Mar 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liam-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 11:23am
liam-erd-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 11:23am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
liam-docs ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2025 11:23am
test-liam-app ⬜️ Ignored (Inspect) Mar 21, 2025 11:23am
test-liam-docs ⬜️ Ignored (Inspect) Mar 21, 2025 11:23am
test-liam-erd-sample ⬜️ Ignored (Inspect) Mar 21, 2025 11:23am

Copy link

supabase bot commented Mar 21, 2025

Updates to Preview Branch (devin/1742555063-biome-warning-to-error) ↗︎

Deployments Status Updated
Database Fri, 21 Mar 2025 11:14:53 UTC
Services Fri, 21 Mar 2025 11:14:53 UTC
APIs Fri, 21 Mar 2025 11:14:53 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Configurations Fri, 21 Mar 2025 11:14:54 UTC
Migrations Fri, 21 Mar 2025 11:14:54 UTC
Seeding Fri, 21 Mar 2025 11:14:54 UTC
Edge Functions Fri, 21 Mar 2025 11:14:54 UTC

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

Co-Authored-By: hirotaka.miyagi@route06.co.jp <hirotaka.miyagi@route06.co.jp>
Copy link
Member

@MH4GF MH4GF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Member

@junkisai junkisai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!!

@junkisai junkisai added this pull request to the merge queue Mar 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 24, 2025
@MH4GF MH4GF added this pull request to the merge queue Mar 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 25, 2025
@MH4GF MH4GF added this pull request to the merge queue Mar 25, 2025
github-merge-queue bot pushed a commit that referenced this pull request Mar 25, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…o-error

feat: make biome suppressions/unused a linting error
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants