-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/directly use supabase client #944
base: main
Are you sure you want to change the base?
Conversation
- Added a new script to generate Supabase TypeScript types in package.json. - Imported Supabase client creation functions and updated exports in index.ts. - Updated .gitignore to exclude generated TypeScript types file.
- Replaced Prisma client with Supabase client for fetching project data. - Updated the handling of empty project states to account for null responses. - Adjusted the date formatting for project creation dates in the UI. - Added a new SQL migration file to set permissions for the Project table in Supabase.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Updates to Preview Branch (feat/directly-use-supabase-client) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
The schema changes provided indicate a significant transition from using Prisma as the primary database client to adopting Supabase for data management within the project. Below is a detailed review of the changes:
Overall, the changes present a strategic shift towards utilizing Supabase, which can offer benefits like real-time capabilities and simplified database management. However, it is imperative to conduct thorough testing to ensure that the migration does not introduce new issues, particularly regarding data integrity, user experience, and security. Additionally, documentation should be updated to reflect these changes for future developers working on the project. Migration URL: https://liam-app-git-staging-route-06-core.vercel.app/app/projects/4/migrations/5 |
PR Code Suggestions ✨Explore these optional code suggestions:
|
…ct ID from temp file
Issue
Why is this change needed?
What would you like reviewers to focus on?
Testing Verification
What was done
🤖 Generated by PR Agent at 41bcf63
Project
table in Supabase.Detailed Changes
index.ts
Integrate Supabase client in database module
frontend/packages/db/src/index.ts
ProjectsPage.tsx
Refactor ProjectsPage to use Supabase client
frontend/apps/app/features/projects/pages/ProjectsPage/ProjectsPage.tsx
20250319115250_remote_schema.sql
Add Supabase permissions migration for Project table
frontend/packages/db/supabase/migrations/20250319115250_remote_schema.sql
Project
table.anon
,authenticated
, andservice_role
roles.package.json
Add Supabase types generation script
frontend/packages/db/package.json
Additional Notes