Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ update Mobile Safari snapshot for visual regression testing #734

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

junkisai
Copy link
Member

@junkisai junkisai commented Feb 14, 2025

User description

I updated the desktop snapshot in the PR at #708, but since tests for the mobile version were added in the subsequent PR at #712, I updated the snapshot accordingly.

Related Issue

Testing

Other Information


PR Type

Tests


Description

  • Updated the Mobile Safari snapshot for visual regression testing.

  • Adjusted the snapshot to account for mobile version tests added in a subsequent PR.


Changes walkthrough 📝

Relevant files

Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @junkisai junkisai self-assigned this Feb 14, 2025
    Copy link

    changeset-bot bot commented Feb 14, 2025

    ⚠️ No Changeset found

    Latest commit: 0840931

    Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

    This PR includes no changesets

    When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

    Click here to learn what changesets are, and how to add one.

    Click here if you're a maintainer who wants to add a changeset to this PR

    Copy link

    vercel bot commented Feb 14, 2025

    The latest updates on your projects. Learn more about Vercel for Git ↗︎

    3 Skipped Deployments
    Name Status Preview Comments Updated (UTC)
    test-liam-docs ⬜️ Ignored (Inspect) Feb 14, 2025 7:48am
    test-liam-erd-sample ⬜️ Ignored (Inspect) Feb 14, 2025 7:48am
    test-liam-erd-web ⬜️ Ignored (Inspect) Feb 14, 2025 7:48am

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link
    Member

    @sasamuku sasamuku left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thanks!

    @sasamuku sasamuku added this pull request to the merge queue Feb 14, 2025
    Merged via the queue into main with commit e446fc2 Feb 14, 2025
    18 checks passed
    @sasamuku sasamuku deleted the feat/update-snapshot branch February 14, 2025 08:04
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants