Feature connector md #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li2109
requested changes
May 30, 2023
| import java.nio.file.Paths; | ||
|
|
||
| /** Implementation of DocumentConnector for Md files. */ | ||
| public class MdConnector extends DocumentConnector<MdReadOption> { |
| @@ -0,0 +1,29 @@ | |||
| package ai.knowly.langtorch.connector.md; | |||
| /** Implementation of ReadOption for Markdown files. */ | ||
| @Data | ||
| @Builder(toBuilder = true, setterPrefix = "set") | ||
| public class MdReadOption implements ReadOption { |
| import static com.google.common.truth.Truth.assertThat; | ||
| import static org.junit.jupiter.api.Assertions.assertThrows; | ||
|
|
||
| public class MdConnectorTest { |
| /** Implementation of DocumentConnector for Md files. */ | ||
| public class MdConnector extends DocumentConnector<MdReadOption> { | ||
| private MdConnector(){}; | ||
|
|
| @Override | ||
| protected String read(MdReadOption readOption) throws IOException { | ||
| // Read the Markdown file content | ||
| return new String(Files.readAllBytes(Paths.get(readOption.getFilePath()))); |
There was a problem hiding this comment.
adding charset
new String(
Files.readAllBytes(Paths.get(readOption.getFilePath())), StandardCharsets.UTF_8);
build.gradle
Outdated
| @@ -120,6 +120,8 @@ dependencies { | |||
| implementation 'org.apache.pdfbox:pdfbox:2.0.28' | |||
| // Reading CSV | |||
| implementation 'org.apache.commons:commons-csv:1.10.0' | |||
| // Reading Markdown | |||
There was a problem hiding this comment.
this dependency is not used. please remove it.
|
Btw, could you update the package from "csv" to "spreadsheet"? |
Please also resolve the detected code smell issues |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update implements the basic ability of the connector to read content from the md file