Expose keep_excessive_supervision parameter #1077
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when supervision is slightly longer than recording user gets very confusing message about multiple channels:
This is because keep_overlapping is False and thus we filter out those bad supervisions. And keep_overalapping actually has nothing about the problem of wrong supervision times. One better expose keep_excessive_supervision parameter to method and provide more straightforward assert message.