-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workload tests adapted to centralized result logging #1910
Conversation
36360db
to
e7e2bdd
Compare
spec test result the same as for main branch (still some failures but those don't not seem to be caused by this change). |
We'll try to pull down and push up to verify github actions with no issues and manual testing prior to merging. |
task_start_time = Time.utc | ||
testsuite_task = "smf_upf_core_validator" | ||
Log.for(testsuite_task).info { "Starting test" } | ||
CNFManager::Task.task_runner(args, task: t) do |args, config| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martin-mat Are we losing the ability to track test start/end times with this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start time of every test case moved to the task runner
https://github.com/cnti-testcatalog/testsuite/blob/main/src/tasks/utils/task.cr#L113
and reported along with test case result the same way as before the changes
https://github.com/cnti-testcatalog/testsuite/blob/main/src/tasks/utils/task.cr#L121
I'm not aware that test case duration/end time is recorded anywhere. But possible to introduce easily if needed.
e7e2bdd
to
35cd5f6
Compare
rebased |
Just tried running the build for this. There are some tests that are failing on repeated attempts. https://github.com/cnti-testcatalog/testsuite/actions/runs/8232211049 |
35cd5f6
to
2446863
Compare
Signed-off-by: Martin Matyas <martin.matyas@tietoevry.com>
2446863
to
ada72ee
Compare
fixed. I fixed reasons for: helm, operator_test, points , validate_config. Can you please re-run github actions? Thanks. |
|
Description
Workload tests adapted to cenralized result logging
Issues:
Refs: #1861
How has this been tested:
Types of changes:
Checklist:
Documentation
Code Review
Issue